Update compare branches button to btn-confirm
What does this MR do?
Closes #273283 (closed). Updates the compare branches and continue
button when creating a new merge request.
Screenshots (strongly suggested)
Before | After |
---|---|
-
Audit the entire page, noting how each button is being used. This may mean adding content in order to fully fill out the page. -
Make any updates needed in an MR in order to align all buttons on the page with the guidelines written in Pajamas. This includes using the correct category, variant, positioning, placement, and hierarchy. -
If substantial changes are necessary, connect with the designer responsible for that area of the application so they are aware of the upcoming changes. -
Add before and after screenshots to your issue and MR. -
If no changes are necessary, still add screenshots to your issue. These will serve as examples for other designers. Make a note that no changes were needed. -
For all issues (even if no changes are needed), ping another Foundations member for review. -
Once the issue/MR has been reviewed and merged (when applicable), close the related issue.
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #273283 (closed)
Edited by Jarek Ostrowski