Update secondary nav element right margin to 8
What does this MR do?
Closes #273297 (closed). Changes the secondary nav controls right margin from 10px to 8px. This is a general CSS change that will propagate in other places, such as:
- http://localhost:3000/admin/users
- http://localhost:3000/dashboard/groups
- http://localhost:3000/groups/h5bp/-/milestones
- http://localhost:3000/groups/h5bp/-/labels
- Nearly everywhere
.nav-controlsis used
Why?
In a lot of these cases, we are overriding these margins to use gl-ml-3 or gl-mr-3 since we use the rule of 8. We should really be using 8px to space these nav-control buttons, not 10. With only a 2px difference, there shouldn't be any style breakage, but it's important to note this is a style used on most pages.
Screenshots (strongly suggested)
| Before | After |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #273297 (closed)
Edited by Jarek Ostrowski