Improve the performance bar
What does this MR do?
The performance bar is helpful to detect the issues with replica/primary redirections in the recent rapid action &5590 (closed). However, it soon exposes some limitation:
- The details are sorted by duration. It's impossible to sort them by the time order.
- The user (me) has to scroll and count the number of occurrences of cached, queries in a transaction, replica/primary manually for each request.
- The top bar is expanding, and does not fit into the screen anymore.
Therefore, In this MR, I would love to:
- Add a top section inside the detailed page to display some summaries of the request. The summary is sent from the backend.
- Allow the details to be sorted chronologically, or by duration order.
- Remove redundant information from the top bar. Right now I just shorten some of them, but in the next PR, all of them will be moved into the detailed page
Screenshots (strongly suggested)
Top of the details page in the performance bar
After sorting chronologically, an unexpected bug shows up clearly
Before moving details into the detail page
After moving details into the detail page, the top bar becomes more compact:
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Quang-Minh Nguyen