Skip to content

Lefthook: Do not reveal RuboCop TODOs in pre-push hook

Peter Leitzen requested to merge pl-doc-lefthook-reveal-rubocop-todo into master

What does this MR do?

Having REVEAL_RUBOCOP_TODO=1 reveals RuboCop TODOs and sometimes prevents pushing code.

This commit hides any RuboCop TODOs in lefthook.

This came up during the review of !56827 (comment 531078988).

Reproduction

  • export REVEAL_RUBOCOP_TODO=1
  • Make an RuboCop rule unrelated change to a Ruby file which now contains revealed TODOs
  • bundle exec lefthook run pre-push or git push

Screenshots (strongly suggested)

Before After
Screenshot_from_2021-03-17_14-32-22 Screenshot_from_2021-03-17_14-32-38

Does this MR meet the acceptance criteria?

Conformity

Edited by Peter Leitzen

Merge request reports

Loading