Fix: Do not clear rotation form on validation error
What does this MR do?
A tiny MVC for: #324688 (closed) where do not clear the rotation form unless you are adding a new rotation or have successfully submitted the form to allow for validation errors. We do this by updating the logic for the @hide
and @show
logic slightly to be gated.
How/What to test
This feature needs the minimal license is GitLab Premium
To validate this merge:
- Navigate to Operations => On-call Schedules or direct link is
your_project/-/oncall_schedules
e.g. http://127.0.0.1:3000/gitlab-org/gitlab-shell/-/oncall_schedules. - Click "Add schedule on empty state"
- Add a base schedule
- Click "Add a rotation"
- Add a base rotation with any name
- Attempt to create a new rotation with the same name
- The form should not clear when you get the error but should clear if you elect to add a new rotation
Screenshots (strongly suggested)
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
- [-] Documentation (if required)
- [-] Code review guidelines
- [-] Merge request performance guidelines
- [-] Style guides
- [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #324688 (closed)