Skip to content

Make scanner profile form composable

Dheeraj Joshi requested to merge djadmin-scanner-profile-composable into master

Related issue - #325238 (closed)

What does this MR do?

This MR makes the DAST scanner profile form reusable / composable, as we plan to include the form inline in another place (which is DAST Scans form). The main idea is to create success and cancel event handles, move the form actions outside the component and let the parent handle it.

It also

  • adds an optional showHeader prop, which will be used later
  • make the submit button enabled always to conform with the design specs

More importantly, this also adds feature specs for DAST Scanner Profile form to make sure there is no regression during this refactor and for future coverage as well

Screenshots (strongly suggested)

No visual changes except that submit button is enabled always

Local testing

Navigate to the DAST Scanner profile form in your GDK /:namespace/:project/-/security/configuration/dast_scans/dast_scanner_profiles/new

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Dheeraj Joshi

Merge request reports

Loading