Adjust gitlab_database_transaction_seconds bucket
What does this MR do?
gitlab_database_transaction_seconds was added in 56ae34e4. In that commit, we used the default bucket of Prometheus. In a following up MR (!56005 (merged)), that metric was forced to use the same bucket with other histograms in the same observer, accidentally. It makes the histogram inaccurately recorded, especially for the transactions hanging more than 250ms.
This MR is to adjust the bucket of gitlab_database_transaction_seconds. As we care about the transaction if it hangs for a while, I removed the bottom end of the default bucket. The bucket now becomes [0.05, 0.25, 1, 2.5, 5, 10]. When looking at the current average transaction duration, this bucket seems to be reasonable:
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team