Skip to content

Add trailing slash to Omnibus wss address links

Justin Farmiloe requested to merge fix-omnibus-wss-address-2 into master

What does this MR do?

Modifies the Omnibus kas-address shown in various places to have a trailing /.

Same rationale as !55565 (merged) which fixed some occurrences but unfortunately missed the others. This change makes all references consistent.

Background:

When KAS is enabled on the GL instance the following config is added to /var/opt/gitlab/nginx/conf/gitlab-http.conf which expects the trailing / to be present in requests from the agent:

  location /-/kubernetes-agent/ {
    proxy_pass http://localhost:8150/;
  }

If it isn't, the GL instance responds with a redirect and this generates the following error on the agent:

{"level":"error","time":"2021-03-01T21:13:05.380Z","msg":"Reverse tunnel","mod_name":"reverse_tunnel","error":"Connect(): rpc error: code = Unavailable desc = connection error: desc = \"transport: Error while dialing failed to WebSocket dial: expected handshake response status code 101 but got 301\""}

Related issues

Author's checklist (required)

Do not add the feature, frontend, backend, ~"bug", or database labels if you are only updating documentation. These labels will cause the MR to be added to code verification QA issues.

When applicable:

Review checklist

All reviewers can help ensure accuracy, clarity, completeness, and adherence to the Documentation Guidelines and Style Guide.

1. Primary Reviewer

  • Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.

2. Technical Writer

  • Technical writer review. If not requested for this MR, must be scheduled post-merge. To request for this MR, assign the writer listed for the applicable DevOps stage.

For more information about labels, see Technical Writing workflows - Labels.

For suggestions that you are confident don't need to be reviewed, change them locally and push a commit directly to save others from unneeded reviews. For example:

  • Clear typos, like this is a typpo.
  • Minor issues, like single quotes instead of double quotes, Oxford commas, and periods.

For more information, see our documentation on Merging a merge request.

3. Maintainer

  1. Review by assigned maintainer, who can always request/require the above reviews. Maintainer's review can occur before or after a technical writer review.
  2. Ensure a release milestone is set.
  3. If there has not been a technical writer review, create an issue for one using the Doc Review template.
Edited by Marcia Ramos

Merge request reports

Loading