Skip to content

Add plan name matcher between GitLab and CustomersDot

Etienne Baqué requested to merge 321364-plan-name-to-match-customersdot into master

What does this MR do?

Related to #321364 (closed)

After adding premium and ultimate records to .com (in this MR), a discrepancy between .com and CustomersDot was created: instead of using premium and ultimate, CustomersDot uses the following plan names: premium_saas and ultimate_saas.

When making an API call from the GitLab Billing page for a group that has premium or ultimate plan, this difference will fail to return data from CustomersDot, as these plan names don't quite match between both platforms.

This MR introduces a matcher to take care of these differences.

Screenshots

Just to double-check nothing was broken, I created a new group on my local GitLab then purchased a Premium license.

Screenshot_from_2021-03-24_16-06-34

Screenshot_from_2021-03-24_16-05-13

As expected, the plans record this new subscription is pointing to, is still silver:

Screenshot_from_2021-03-24_17-43-55

More about fixing this in this MR.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #321364 (closed)

Edited by Etienne Baqué

Merge request reports

Loading