Run CI_PRE_CLONE_SCRIPT in sub-shell
What does this MR do?
This fixes a bug in the CI_PRE_CLONE_SCRIPT for gitlab-org/gitlab that we discovered in gitlab-com/gl-infra/production#4014 (comment 532840355).
It is not safe for the script to call exit unless it runs in a sub-shell. This MR puts the whole script in a sub-shell.
After merging this we need to update the CI_PRE_CLONE_SCRIPT in the gitlab-org/gitlab project settings.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team