Linear traversal query for Namespace#ancestors [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
Adds linear traversal query for Namespace#ancestors
which has better query performance over recursive CTEs. Refactored from !36025 (closed).
Screenshots (strongly suggested)
Queries
https://console.postgres.ai/gitlab/gitlab-production-tunnel/sessions/3896/commands/13413Original query
WITH RECURSIVE "base_and_ancestors" AS (
(
SELECT
"namespaces".*
FROM
"namespaces"
WHERE
"namespaces"."type" = 'Group'
AND "namespaces"."id" = 1755573)
UNION (
SELECT
"namespaces".*
FROM
"namespaces",
"base_and_ancestors"
WHERE
"namespaces"."type" = 'Group'
AND "namespaces"."id" = "base_and_ancestors"."parent_id"))
SELECT
"namespaces".*
FROM
"base_and_ancestors" AS "namespaces"
https://postgres.ai/console/gitlab/gitlab-production-tunnel/sessions/3849/commands/13120New query
SELECT
"namespaces".*
FROM
"namespaces"
WHERE
"namespaces"."id" IN (9970, 1755573)
https://postgres.ai/console/gitlab/gitlab-production-tunnel/sessions/3849/commands/13125New query with hierarchy order
SELECT
"namespaces".*,
ABS(3 - array_length(traversal_ids, 1)) AS depth
FROM
"namespaces"
WHERE
"namespaces"."id" IN (9970, 1755573)
ORDER BY
"depth" ASC
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team