Skip to content

Audit and update buttons on Projects::IssuesController#new

What does this MR do?

  • Move the “Please review the contribution guidelines for this project.” text before the Submit issue and Cancel buttons so that it would be read before submission for screen reader users. This helps make them aware of its presence before submitting the form, in which case it might never be encountered.
  • Align Cancel button left.
  • Change Submit issue button label to Create issue.
  • Update MR approval button order and size.
  • Update edit MR and issue button order and variants.

Screenshots

Before After Notes
CleanShot_2021-03-22_at_16.18.29_2x CleanShot_2021-03-22_at_16.44.32_2x Text placed before buttons. Buttons left aligned. Submit button label updated to Create.
CleanShot_2021-03-22_at_16.18.42_2x CleanShot_2021-03-22_at_16.44.43_2x Mobile view for above.
CleanShot_2021-03-22_at_17.00.36_2x CleanShot_2021-03-22_at_16.49.24_2x Text placed before buttons. Buttons left aligned. Submit button label updated to Create.
CleanShot_2021-03-22_at_17.00.49_2x CleanShot_2021-03-22_at_16.49.37_2x Mobile view for above.
CleanShot_2021-03-22_at_17.02.50_2x CleanShot_2021-03-23_at_11.10.16_2x Button order changed and Delete irreversible action placed on its own.
CleanShot_2021-03-22_at_17.03.25_2x CleanShot_2021-03-23_at_11.10.33_2x Mobile view for above.
CleanShot_2021-03-23_at_12.53.00_2x CleanShot_2021-03-23_at_13.48.00_2x Buttons reordered, realigned, and use the small size to further next them within the flow and avoid conflict with the footer buttons.
CleanShot_2021-03-23_at_12.53.35_2x CleanShot_2021-03-23_at_13.48.13_2x Mobile view for above.
CleanShot_2021-03-23_at_13.57.01_2x CleanShot_2021-03-23_at_13.56.36_2x Better alignment of buttons to text and each other.
CleanShot_2021-03-23_at_14.06.57_2x Updated focus order for new issue
CleanShot_2021-03-23_at_14.06.16_2x Updated focus order for editing merge request
CleanShot_2021-03-23_at_14.16.08_2x CleanShot_2021-03-23_at_14.21.21_2x Change button variants, reorder and reposition them.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

N/A

Security

N/A

Related to #273313 (closed), #273321 (closed)

Edited by Jeremy Elder

Merge request reports

Loading