Master broken: rspec ./spec/workers/service_desk_email_receiver_worker_spec.rb:28
requested to merge 325579-master-broken-rspec-spec-workers-service_desk_email_receiver_worker_spec into master
What does this MR do?
Fixes a flaky spec where each ActiveJob queue adapters were getting set to a new instance of ActiveJob::QueueAdapters::TestAdapter
. Setting the queue_adapter
to :test
, we ensure that all queue adapters are using the same test adapter.
It also un-quarantines service desk receiver spec, ala !57165 (merged)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #325579 (closed)
Edited by Brett Walker