Skip to content

Check access for only the requesting user when determining subscribed status

Tiger Watson requested to merge skip-individual-subscribed-access-filter into master

What does this MR do?

Checks access only for requesting user when checking if subscribed

We don't need to check access for all participants when determining if a single user is subscribed to a Subscribable, only the current user.

By not checking access in bulk we skip instantiating a ProjectTeam and querying for associated members, which is expensive for projects with many members.

#325337 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Thong Kuah

Merge request reports

Loading