Skip to content

Group-level "DevOps Adoption" - Show data table [RUN AS-IF-FOSS]

What does this MR do?

This MR extends the devops adoption admin feature by allowing it to be used in a group context too.

Things to note for the group level feature;

  • A group will be automatically enabled if disabled when browsed to
  • The add / remove modal button has been updated to refer to sub groups
  • It is not possible to disable the active group
    • The active group does not appear in the modal
    • The delete / remove button is disabled for the active group
      • I opted to disable the button instead of hide it in order to prevent differences in row heights.
  • The add / remove subgroups button is removed from groups without subgroups

This is behind the feature flag group_devops_adoption

Feature flag rollout issue: #323159 (closed)

Screenshots (strongly suggested)

Admin feature Group with subgroups Group with subgroups modal Group without subgroups Group without subgroups tooltip
Screenshot_2021-03-24_at_12.22.03 Screenshot_2021-03-24_at_12.22.24 Screenshot_2021-03-24_at_12.22.45 Screenshot_2021-03-24_at_12.22.29 Screenshot_2021-03-24_at_16.42.57

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #321083 (closed) #321969 (closed)

Edited by Miguel Rincon

Merge request reports

Loading