Send invited users to sign up instead of sign in when possible
What does this MR do?
- Sends the invited user to sign up instead of sign in under these conditions
- the user doesn't exist with the email used for invite
- sign-ups are allowed for the instance
- member still exists to be valid to accept the invite
- applies the correct notice message if sent to sign-up instead of sign-in
How to test locally(gdk)
- Invite a new user to a project via email.
- go to
http://localhost:3000/rails/letter_opener/to find the email. - click 'join' on that email and validate it redirects to sign-up.
Screenshots (strongly suggested)
When qualifying, send to sign up instead...
Screen_Recording_2021-03-23_at_11.11.11_AM
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #325288
Edited by Doug Stull