Fix reindexing retry for the notes migration
What does this MR do?
This is a follow-up from !53013 (merged). I noticed that after a reindexing failure the notes migration doesn't retry, but keeps checking the same task_id since we keep the same one in https://gitlab.com/gitlab-org/gitlab/blob/master/ee/elastic/migrate/20210302104500_migrate_notes_to_separate_index.rb#L77 when we should have set it to nil
to start another reindexing for that slice.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?- [-] I have included a changelog entry.
-
I have not included a changelog entry because this is not user facing change.
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related to #297646 (closed)
Edited by Dmitry Gruzd