Resolve "Query Performance Investigation - Query ID 2128753358500210093 (internal_ids table)"
requested to merge 325431-query-performance-investigation-query-id-2128753358500210093-internal_ids-table into master
What does this MR do?
Reduce the time that we hold the update lock for internal id
We are performing an increment to the metrics when we have a lock on an internal id row, but the metric update has a mutex on the prometheus metric client, which may cause us to hold the lock on the internal id row for longer than we need.
To remove this, we move the counter outside of the lock.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #325431 (closed)
Edited by Marc Shaw