Ensure search param is kept in scrolled commit
What does this MR do?
There is an issue when search commit terms are not kept when scrolling down for more commits. In this MR we fix this so the search term is kept.
Bug (no search when scrolled |
Fixed (has search when scrolled |
---|---|
24551-Bug | 24551-Fixed |
Note: If the user hits enter
on the search term, the bug does not happen. It only exists when the user types the search and does not click the enter
on their keyboard.
Testing Case
- Go to Repository > Commits
- Put in a search term and wait (do not press
enter
) - Scroll down to load more results
-
the search term is included in the request
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #24551 (closed)
Edited by Samantha Ming