Skip to content

Moves diff notes comment icon to CSS

Phil Hughes requested to merge ph/diffCommentIconToCss into master

What does this MR do?

Moves the comment icon on diffs to CSS. This saves us creating an icon component for each diff row.

For a smaller merge request and an average of 5 runs I got the following numbers:

Before After
4500ms 4000ms

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading