Skip to content

A blocked URL for a push mirror is a hard failure

Nick Thomas requested to merge 300884-fix-push-mirror-failures into master

What does this MR do?

Rework push mirrors so they treat an invalid mirror URL due to the operation of Gitlab::UrlBlocker as a hard failure.

Without this change, push mirrors with an invalid URL are retried indefinitely, which is very bad.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #300884 (closed)

Related to https://gitlab.com/gitlab-com/gl-infra/production/-/issues/3987

Edited by Nick Thomas

Merge request reports

Loading