Skip to content

Refactor artifactable concern [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Max Orefice requested to merge mo-refactor-artifactable into master

Ref: #238464 (closed)

What does this MR do?

This is a preliminary step toward replicating our PipelineArtifact with geo.

This MR refactors some shared logic used by 2 domains: JobArtifact & PipelineArtifact.

It includes an existing abstraction called ObjectStorable and extend Artifactable concern for EE.

It also adds dedicated specs to those 3 scopes.

Note: This does not change any existing behaviour as this concern is included in both ActiveRecord objects mentioned above.

Why are we doing this?

The grouptesting is currently replicating our PipelineArtifact with geo.

During the investigation of this new feature we discovered in our POC that would need those 3 scopes to replicate our data with geo.

This MR aims to consolidate our codebase by sharing the same logic between our 2 models.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mark Chao

Merge request reports

Loading