Switch the source for Diffs suggestion commit message to the MR Notes store
What does this MR do?
For #300749 (closed)
Because the MR Metadata is always loaded when the page first starts up for any MR page, this MR:
- Switches the authoritative source of MR Metadata for the suggestion commit placeholder to be the "global"
mr_notes
store instead of the more specificdiffs
store.
MR | Description |
---|---|
!56575 (merged) | This MR ingests the required endpoint into the MR Notes app. |
!56594 (merged) | This MR actually loads the diffs_metadata.json data and places it into the state for the MR Notes app |
We're here |
This MR switches the Diffs app to use the MR Notes app location to fill the placeholder data |
!58136 (merged) | This MR makes changes to enable getting the Diff file information into the Notes app on the Overview tab |
Screenshots (strongly suggested)
Note here that this switch to the new data source doesn't change the Diffs output, but does significantly fix the Overview output.
To be clear, this change is not intended to fully fix the Overview output (which is why it still has unhydrated variables).
The fixes in the Overview tab are just a side effect of the update to the Diffs app.
Before | After | |
---|---|---|
Changes | ||
Overview |
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. - [-] I have not included a changelog entry because _____.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Thomas Randolph