Skip to content

Listen on localhost for Gitaly's Prometheus

What does this MR do?

This MR updates Gitaly's Prometheus endpoint to listen on localhost instead of all interfaces, which on macOS causes a popup asking to allow this behaviour:

Screen_Shot_2021-03-24_at_4.45.06_PM

As well as stopping the popup from occurring, it's generally best practice for services to listen on localhost unless explicitly required otherwise.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Ash McKenzie

Merge request reports

Loading