Use search request to filter refs selection
What does this MR do?
Switch from a fixed filter and utilize the search param of the refs request.
Doing this because the endpoint is limited to 100 results. So we need to make another request passing the search param of the search term to filter down the results that are returned.
Testing Case
This feature is behind a Feature Flag, to turn on:
Feature.enable(:compare_repo_dropdown)Find a project that has over 100 tags.
- Navigate to Repository > Compare
- Search for a tag that is not displayed in the dropdown
-
It will return the searched tag
| Initial Dropdown Items | Filtered Dropdown Item |
|---|---|
 |
 |
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #324612 (closed)
Edited by Samantha Ming