Make site profile form composable
Related #325239 (closed)
What does this MR do?
This MR makes the DAST site profile
form reusable / composable, as we plan to include the form inline in another place (which is DAST Scans
form). The main idea is to create success
and cancel
event handles, move the form actions outside the component and let the parent handle it.
- It also adds an optional
showHeader
prop, which will be used later - Adds feature specs for DAST site Profile form to make sure there is no regression during this refactor and for future coverage as well
Screenshots (strongly suggested)
No visual changes
Local testing
Navigate to the DAST Scanner profile form in your GDK /:namespace/:project/-/security/configuration/dast_scans/dast_site_profiles/new
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because there are no using facing changes.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team