Skip to content

Select specific columns needed for Users in mailers [RUN ALL RSPEC] [RUN AS-IF-FOSS]

Drew Blessing requested to merge dblessing_mailer_select into master

What does this MR do?

Related to #325332 (closed)

Seek and destroy User.find to cut down on select * from user and to select specific columns where feasible. I think mailers is a great candidate for this because:

  • most of the time we just need :name
  • we send tons of mail, especially issue and MR mailers

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Drew Blessing

Merge request reports

Loading