Skip to content

Fix inconsistent production environment definition on VSA

Shinya Maeda requested to merge fix-obsolte-production-identifier into master

What does this MR do?

We recently introduced the first class concept for production environments. As you can read in the docs, this feature allows users to explicitly define production environment regardless of the environment name. All features in GitLab that depends on production environments should identify the production environments via this SSOT feature, instead of building a unique business logic per domain.

This MR improves the Allow other names for VSA production stage by replacing the obsolete PRODUCTION_ENVIRONMENT_IDENTIFIERS by the new feature. This subsequently fixes a bug that VSA doesn't work for production environments which don't follow the current matching pattern, such as gprd.

FYI, you can see the new feature's regexp in https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/models/environment.rb#L469.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Shinya Maeda

Merge request reports

Loading