Add option to specify target type for DAST Profiles
Related issue - #294059 (closed)
What does this MR do?
-
Adds a new feature flag(added by !58723 (merged))security_dast_site_profiles_api_option
- Adds target type options (
website
,rest api
) and put the changes behind the flag - Hides authentication section when
rest api
option is selected
Corresponding backend MR - !58723 (merged)
Screenshots (strongly suggested)
- Profile form
Website |
Rest API |
---|---|
- Summary section
How to test this
- Enable the feature flag.
echo " Feature.enable(:security_dast_site_profiles_api_option)" | rails c
-
Navigate to the DAST profile library page in your GDK:
/:namespace/:project/-/security/configuration/dast_profiles#site-profiles
-
Select
create new site profile
Known issues
- Updating a site profile might not work as excepted, as backend is in development.
- When switching between
Rest API
andWebsite
options, the auth fields would get populated with weird Js objects, will be fixed by #328376 (closed)
These issues should not block the MR, as the entire feature is in dev & behind dedicated feature flag.
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because feature flaged .
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Alex Kalderimis