Skip to content

Improve error handling of runner instructions

Miguel Rincon requested to merge 326018-handle-missing-instruction-error into master

What does this MR do?

Improve error handling of runner instructions modal

This change improves the error handling when instructions cannot be loaded or are empty.

It also fixes a case for sub-groups by using full_path.

Screenshots (strongly suggested)

Before:

  • Console error appears as user has not acces, but this is not handled correctly
  • Alert is not shown

2021-03-26_14.54.34

After:

  • Console error is gone
  • Alert is shown

2021-03-26_14.55.00

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #326018

Edited by Miguel Rincon

Merge request reports

Loading