Reduce number of SQL queries in Profiles::SlacksController#edit
requested to merge 21044-controller-profiles-slackscontroller-edit-executes-more-than-100-sql-queries into master
What does this MR do?
When we pass the whole projects
array to the ServicesHelper
, Rails attempts to serialize the whole project
object along with its relations. Notably project_import_data
and tags
cause a bunch of N+1 queries. By manually serializing the project
object and explicitly calling only the attributes we need, the number of SQL queries is reduced considerably.
On my local, the number of SQL queries go from 50 queries down to 11.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #21044 (closed)
Edited by Justin Ho Tuan Duong