Ensure project_iid before calling drop! on the pipeline [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
We need ensure_project_iid to run without any parent transaction, otherwise the InternalId table for that scope, in our case project, will be locked for the entire transaction.
We are currently calling ensure_project_iid in the seed chain here
However, this is only going to work if this code is called before we try to save the pipeline. Looking at the list in the pipeline chain here, one of the issues is if there is an error in the chain before the seed method in the chain is called, we will call drop! here which will cause the internal id to be locked for the duration of the state transition transaction (from x -> drop), rather than the transaction in InteralId here.
Let's ensure the project_iid is set, before calling the drop state transition when an error occurs.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team