Remove N+1 DB queries from indexing issues in Elasticsearch
What does this MR do?
The #as_indexed_json
method is used to convert individual documents to
the JSON that is sent to Elasticsearch during indexing. We need to
preload the data before it gets to this method. We implemented the
.preload_indexing_data
method in
!56808 (merged) so we just
need to add this to the various classes now. This MR updates it for
Issue
only.
We also slightly refactor the issue_instance_proxy since it's more
efficient to just use the user_id
from the issue_assignees
join
table than to join again to users
and also since it wasn't possible to
get the preload to work without loading all of users.*
which would be
wasteful for a wide table and large numbers of records.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #324745 (closed)