Support SMTP connection pooling when sending emails
What does this MR do?
This adds a new ActionMailer delivery method for sending emails using an SMTP connection pool. This is implemented as a gem under vendor/
so that we can easily extract this in the future.
Related to #230717 (closed)
Testing locally
You can test this by following the instructions in config/initializers/smtp_settings.rb.sample
You may need to set action_mailer.perform_deliveries = true
because this is set to false
in development.
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Heinrich Lee Yu