Add `prepend_mod` and a new JH merge requests review guidance
What does this MR do?
Add a new JH feature review guidance
Next up
- Rename
prepend_if_ee
toprepend_mod_with
- Rename
extend_if_ee
toextend_mod_with
- Rename
include_if_ee
toinclude_mod_with
- Remove
::EE
orEE
prefix with the module name - Remove
constant_without_prefix
after there's no more prefix passed
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #325800 (closed)
Edited by Lin Jen-Shin