Delete all issuable todos asynchronously when issuable is destroyed [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
The Issuable::DestroyService gets called for DELETE /api/projects/:id/merge_requests/:merge_request_iid endpoint.
When deleting an issuable (Issue or MergeRequest), the associated Todo records need to be deleted as well. Before this change, it was calling Todo#destroy on each associated todo that results to N+1 issues.
Deletion of todos is now being done asynchronously since it's possible that the deleted issuable has lots of associated todos and doing it synchronously can take time. This also makes it consistent with how we delete todos in other cases (other services can be found under app/services/todos/destroy/ directory).
Deletion is being done in batches to avoid statement timeouts in case there are a lot of todos to be deleted.
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #325689 (closed)