Drop new builds when CI quota is exceeded [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
Related to https://gitlab.com/gitlab-org/gitlab/-/issues/323486
When a new pipeline is created, just before it's initial processing, we check the namespace's CI minutes quota. If the builds are assignable only to shared runners and the namespace is out of minutes, we drop all of them with ci_quota_exceeded failure reason.
Database queries
Ci::Minutes::PipelineEnforceQuotaService.new(...).drop_builds_without_specific_runners- with
HAVING(current implementation): https://console.postgres.ai/shared/201a9067-1c1b-4c48-9d62-34cd0181ec18 - with a CTE for build tags: https://console.postgres.ai/shared/d6617229-ec76-4107-b8b6-d360ec8ce7ce
Ci::Runner.instance_type.with_positive_cost_factor_for(project).exists?https://console.postgres.ai/shared/630598ac-ca7c-4290-a0b9-95d0f115dbe3
Screenshots (strongly suggested)
Pictures
Project with shared runners only:
Everything is dropped with a quota exceeded message.
Project with shared and specific runners:
The first stage build is allowed to run.
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because this is behind a feature flag.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Marius Bobin