Add db_load_balancing_counters to structured_log
What does this MR do?
Adds ::Gitlab::Metrics::Subscribers::ActiveRecord::DB_LOAD_BALANCING_COUNTERS
to the Gitlab::InstrumentationHelper.keys
.
We introduced counters db_replica_count, db_replica_cached_count, db_primary_count, db_primary_cached_count, but they were not added to the Sidekiq structured log, because it uses Gitlab::InstrumentationHelper.keys
Now, when we introduced load_balancing for Sidekiq, we would like to have this counters in a log as well
Related to: #326225 (closed)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Kamil Trzciński (Back 2025-01-01)