Skip to content

Display error message when dashboard activity fetch fails

Tom Quirk requested to merge add-error-handler-dashboard-activity into master

What does this MR do?

Refactors Pager.init to include error handling capabilities. We then use this to createFlash when activity fetching fails.

This MR will also resolve #262588 (closed)

Screenshots (strongly suggested)

Current behavior: when request fails, loading spinner disappears with no error message.

This MRs behaviour: when request fails, loading spinner disappears and generic error message is displayed.

Before (dashboard activity) After (dashboard activity)
before-error-handler after-error-handler
User activity Project activity Group activity
Screen_Shot_2021-03-31_at_1.41.27_pm Screen_Shot_2021-03-31_at_1.42.50_pm Screen_Shot_2021-03-31_at_1.42.34_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Tom Quirk

Merge request reports

Loading