Resolve "Apply Links Layer to Pipeline Editing Vis"
What does this MR do?
Replace duplicated logic in the pipeline editor visualization with our reusable component LinksLayer
which in turn uses LinksInner
, both of which take care of generating the lines between jobs. Originally the viz was the first one to use that logic, but with the effort on the current pipeline graph, these components came to be and are now used by the pipeline running graph.
This MR now take this component and switch it out with the logic to calculate the links. Some other minor changes had to occurs to make this generic change work. For example, we currently pass a PIPELINE_ID
of 0 to the LinksLayer
component because the viz doesn't have the same need to differentiate job by pipelines (think up and downstream which could have the same job name, but on different pipeline). So for now we pass a default value of 0, which we could increment when we decide to add up and downstream support in the viz.
Screenshots (strongly suggested)
Nothing changes, here is everything working:
Screen_Recording_2021-04-01_at_1.21.59_PM
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?- [-] I have included a changelog entry.
-
I have not included a changelog entry because no user facing changes.
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #296984 (closed)