Skip to content

Audit and update buttons on Projects::PipelinesController#index

What does this MR do?

  • Updates the Run Pipeline button to use the confirm variant.
  • Updates the buttons to use sentence-case instead of titlecase.
  • Reorders the buttons to Clear runner caches, CI lint, Run pipeline.
  • Updates related tests.
  • Updates any reference to the "Run pipline" button in the docs to use the updated case.

This doesn’t change the casing for "Run Pipeline" when used as a proper noun, for example when referencing the Run Pipeline page.

Screenshots

Before After
CleanShot_2021-03-31_at_10.59.15_2x CleanShot_2021-04-06_at_14.28.36_2x
CleanShot_2021-03-31_at_12.36.53_2x CleanShot_2021-04-06_at_14.28.57_2x
CleanShot_2021-04-06_at_14.43.43_2x CleanShot_2021-04-06_at_14.49.34_2x

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #273293 (closed)

Edited by Jeremy Elder

Merge request reports

Loading