Skip to content

Add notes sorting by created_at to GraphQL

George Koltsov requested to merge georgekoltsov/graphql-update-notes-type into master

What does this MR do?

This MR adds sorting by created_at asc/desc to Note in GraphQL. It's needed for Bulk Import feature that ~"group::import" is working on (https://docs.gitlab.com/ee/user/group/import/).

Please note that I initially wanted to add the same sorting to discussion.notes as well but the return value of discussion.notes is an array and not an ActiveRecord collection.

Screenshots (strongly suggested)

Before After
image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Alex Kalderimis

Merge request reports

Loading