Support multiple columns in column copy triggers
What does this MR do?
Relates to #326569 (closed)
In migration helpers we use "rename" triggers for certain migrations, whenever we need to ensure a destination column keeps the same value as a source column. We need to extend this functionality to support multiple source and destination columns, for migrations where we need to update more than one column at a time. At the same time, we need to maintain backwards compatibility with existing behavior to not break any existing migrations.
That means the install_rename_triggers
and related functions should:
- Create triggers with the same names, same behavior, and same syntax (to prevent diff in
structure.sql
) - Retain compatibility with their existing method signature, while also supporting arrays of column names
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?- [-] I have included a changelog entry.
- [-] I have not included a changelog entry because _____.
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides - [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mayra Cabrera