Skip to content

Add loading prop to filter body and fix search box clear icon

Daniel Tian requested to merge 324246-add-loading-to-filter-body into master

What does this MR do?

On the vulnerability report, we have some dropdowns that filter the vulnerability list:

ksnip_20210331-170555

These dropdowns use a <filter-body> component that internally uses <gl-dropdown>. This MR improves the component by doing the following:

  1. Add a loading prop and a <GlLoadingIcon>:
ksnip_20210401-212438
  1. Fix a bug where the search box was not showing the clear icon when there is text in the search box:
Before After
ksnip_20210331-200020 ksnip_20210331-200009

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Daniel Tian

Merge request reports

Loading