Fix header on group billing page [RUN AS-IF-FOSS] [RUN ALL RSPEC]
What does this MR do?
This bug was reported in this comment.
The group billing header should consistently be relying on plan.name
.
Screenshots (strongly suggested)
The group billing page makes an API call to CustomersDot to retrieve Plan data, through the FetchSubscriptionPlansService
class. Plan names are now returned as they should be read on the billing page:
Before fix
After fix
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Etienne Baqué