Add metric to track querying write location on Request level
What does this MR do?
Introduces gitlab_transaction_primary_write_location_count
Prometheus counter.
This counter will be used to keep track of how many times we queried primary write log location
on the request level.
It uses ActiveSupport::Notifications
to instrument get_write_location.load_balancing
event,
and it introduces subscriber Gitlab::Metrics::Subscribers::LoadBalancing
that will handle and increment the metrics.
primary_write_location_count
will be also added to the lograge and sidekiq structured log.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because _____.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #326225 (closed)
Edited by Nikola Milojevic