Skip to content

Fix project access token creation group settings link

Serena Fang requested to merge sfang-fix-group-settings-link into master

What does this MR do?

Follow up to !57756 (merged)

Since disabling/enabling project access token creation is only allowed for top-level groups, the text that prompts the user to enable token creation should link to the project's group's root ancestor's settings. Previously it would link to the project's group settings, and if that group was not a top-level group, then there'd be no option to enable/disable token creation, which is confusing for the user. The text+link also only render if the user can admin the top-level group (otherwise they'd be brought to a 404 page).

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Enrique Alcántara

Merge request reports

Loading