Skip to content

Fix wrong token in sso url in git message

Gosia Ksionek requested to merge fix_git_access_saml_issue into master

What does this MR do?

in !56867 (merged) I introduced new check for for git actions. As a part of error message there was a link to the sso login. However, I made a mistake and forgot about the case of subgroups :( which caused wrong links to be displayed.

This MR fixes this problem by using root_ancestor method.

Screenshots (strongly suggested)

wrong url: image image

right url: image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading