Stop override tracking in experiment stub [RUN ALL RSPEC]
What does this MR do?
This is removing the override of should_track?
. It got introduced with !55072 (merged) as a temporary solution where we focused on testing tracking with gitlab-experiment
. However, always enable tracking on specs has the side-effect that we can't test an implementation where we don't want to track.
It now calls the original implementation and respect when an experiment does not run for a certain actor or is not active.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because it is a developer facing change.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Douglas Barbosa Alexandre