Remove N+1 query for updating Vulnerability links and identifier_objects [RUN ALL RSPEC] [RUN AS-IF-FOSS]
What does this MR do?
This MR is related to changes described in the following issues.
- Optimize N+1 queries for update_vulnerability_links in StoreSecurityReportsWorker
- Optimize N+1 queries for create_or_update_vulnerability_identifier_object in StoreSecurityReportsWorker
StoreSecurityReportsWorker has a number of places where we can optimize for N+1 queries. We are able to remove these N+1 queries, this worker will impose less pressure on primary db. In this MR, we are trying to optimize the N+1 query issue for vulnerability_links and identifier_objects.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
📋 Does this MR need a changelog?-
I have included a changelog entry. -
I have not included a changelog entry because these changes are behind feature flag.
-
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Saikat Sarkar